Skip to content

chore: Sync e2e with AWS #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2025
Merged

chore: Sync e2e with AWS #839

merged 2 commits into from
Aug 4, 2025

Conversation

sommeeeer
Copy link
Collaborator

@sommeeeer sommeeeer commented Aug 4, 2025 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: be76a41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sommeeeer sommeeeer requested a review from vicb August 4, 2025 12:10
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 4, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@839

commit: be76a41

@sommeeeer sommeeeer removed the request for review from vicb August 4, 2025 12:26
vicb
vicb reviewed Aug 4, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Will approve when ready (aws updated)

Could you please add which PR you have synced in the description

@vicb
Copy link
Contributor

vicb commented Aug 4, 2025

rebased on HEAD

vicb
vicb approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests pass locally 🎉

Thanks !

@vicb vicb merged commit e75150a into opennextjs:main Aug 4, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicb vicb vicb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sommeeeer @vicb